[PATCHSET v2 0/4] xfs: fix leaks and validation errors in logged xattr updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

This short series fixes a couple of places where the deferred xattr
state machine could leak the xfs_da_state structure.  Make log recovery
more robust by checking the op state and attr filter flags of the
recovered log items.

v2: Don't create a new flags namespace for the attr_filter values, since we
    already have one, and add RVB tags.  Fix a crash that Dave found in the
    first patch when node_removename decides to free the da state, but we
    never set the state variable.

If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.

This is an extraordinary way to destroy everything.  Enjoy!
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=attr-intent-fixes-5.19
---
 fs/xfs/libxfs/xfs_attr.c       |   32 ++++++++++++++++++++++----------
 fs/xfs/libxfs/xfs_log_format.h |   10 +++++++++-
 fs/xfs/xfs_attr_item.c         |   34 ++++++++++++++++++++++++++--------
 3 files changed, 57 insertions(+), 19 deletions(-)




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux