On 5/5/22 11:08 AM, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > If there's nothing to repair in phase 4, there's no need to hold up the > FITRIM call to do the summary count scan that prepares us to repair > filesystem metadata. Rearrange this a bit. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > + > + /* > + * If errors remain on the filesystem, do not trim anything. We don't > + * have any threads running, so it's ok to skip the ctx lock here. > + */ > + if (ctx->corruptions_found || ctx->unfixable_errors == 0) > + return 0; > + > +maybe_trim: > + trim_filesystem(ctx); > + return 0; > } I'm a little confused by the unfixable_errors test, is that correct? Why do you bail out if there are 0 unfixable errors? -Eric
