On Thu, May 12, 2022 at 02:02:33PM -0500, Eric Sandeen wrote:
> On 5/5/22 11:05 AM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> >
> > Make sure we detect and correct mismatches between the V5 features
> > described in the primary and the secondary superblocks.
> >
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > ---
>
>
> > + if ((mp->m_sb.sb_features_incompat ^ sb->sb_features_incompat) &
> > + ~XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR) {
>
> I'd like to add a comment about why XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR is special.
> (Why is XFS_SB_FEAT_INCOMPAT_NEEDSREPAIR special? Just because userspace doesn't
> bother to set it on all superblocks in the upgrade paths, right?)
Right -- we only set it on the primary super to force users to run
xfs_repair. Repair will clear NEEDSREPAIR on the primary and all
secondaries before it exits, so there's no point in complaining about
discrepancies in that particular feature bit.
--D
> -Eric
>
