Re: [PATCH v3 3/3] xfs: don't set quota warning values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 10, 2022 at 01:28:00PM -0700, Catherine Hoang wrote:
> Having just dropped support for quota warning limits and warning
> counters, the warning fields no longer have any meaning. Prevent these
> fields from being set by removing QC_WARNS_MASK from XFS_QC_SETINFO_MASK
> and XFS_QC_MASK.
> 
> Signed-off-by: Catherine Hoang <catherine.hoang@xxxxxxxxxx>

Long live quota warning counters!

Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>

--D

> ---
>  fs/xfs/xfs_qm_syscalls.c | 3 +--
>  fs/xfs/xfs_quotaops.c    | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_qm_syscalls.c b/fs/xfs/xfs_qm_syscalls.c
> index 2149c203b1d0..74ac9ca9e119 100644
> --- a/fs/xfs/xfs_qm_syscalls.c
> +++ b/fs/xfs/xfs_qm_syscalls.c
> @@ -217,8 +217,7 @@ xfs_qm_scall_quotaon(
>  	return 0;
>  }
>  
> -#define XFS_QC_MASK \
> -	(QC_LIMIT_MASK | QC_TIMER_MASK | QC_WARNS_MASK)
> +#define XFS_QC_MASK (QC_LIMIT_MASK | QC_TIMER_MASK)
>  
>  /*
>   * Adjust limits of this quota, and the defaults if passed in.  Returns true
> diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
> index 50391730241f..9c162e69976b 100644
> --- a/fs/xfs/xfs_quotaops.c
> +++ b/fs/xfs/xfs_quotaops.c
> @@ -98,7 +98,7 @@ xfs_quota_type(int type)
>  	}
>  }
>  
> -#define XFS_QC_SETINFO_MASK (QC_TIMER_MASK | QC_WARNS_MASK)
> +#define XFS_QC_SETINFO_MASK (QC_TIMER_MASK)
>  
>  /*
>   * Adjust quota timers & warnings
> -- 
> 2.27.0
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux