On Wed, May 04, 2022 at 08:17:19AM +1000, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > When we first allocate or resize an inline inode fork, we round up > the allocation to 4 byte alingment to make journal alignment > constraints. We don't clear the unused bytes, so we can copy up to > three uninitialised bytes into the journal. Zero those bytes so we > only ever copy zeros into the journal. It took me a while to figure out how GFP_ZERO works for krealloc, and it seems like kmalloc and friends always zero the entire length of the kmem_cache, so if krealloc reuses a rounded up allocation the padding is alredy zeroed at that point. So this looks good to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
