On Thu, May 05, 2022 at 05:07:17PM +0200, Christoph Hellwig wrote: > On Thu, May 05, 2022 at 11:12:45AM +0300, Nikolay Borisov wrote: > > nit: You are actually removing this member when copying the struct, that's > > an independent change (albeit I'd say insignificant). Generally we prefer > > such changes to be in separate patches with rationale when the given member > > became redundant. > > This one actually was entirely unused, but yes, this could have been > split into another patch. Cleanest would be to do it in a separate patch, but as it's trivial mentioning it in the changelog would be also sufficient. When code is moved either within file or to another one it's better to keep it 1:1 besides some trivial renames or formatting. It's easy to overlook a line missing. For now no need to resend, I'll add a notice to the changelog.
