On Wed, Apr 27, 2022 at 11:19 PM Dave Chinner <david@xxxxxxxxxxxxx> wrote: > > It's all minor stuff; a 5.18 build regession fix, a deadlock fix > and an update to remove redundant fields from the XFS entry in the > MAINTAINERS file. Done. I had to look twice at that patch going "why does it complain about the xfs flags thing" until I realized it was due to XBF_UNMAPPED being (1 <<31) and the compiler then seeing explicit negative values being assigned. We have a lot of "int flags" in various places, very much not just xfs, and yeah, we should probably try to clean them up. But 99% of the time it's just not worth the noise. And xfs only hit it because you guys literally used up the whole 'int' for it, normally the compiler won't make a peep about it. Thanks, Linus