On 4/25/22 9:12 PM, Darrick J. Wong wrote:
> On Mon, Apr 25, 2022 at 08:33:38PM -0500, Eric Sandeen wrote:
>> This reverts commit 4b8628d57b725b32616965e66975fcdebe008fe7.
>>
>> XFS quota has had the concept of a "quota warning limit" since
>> the earliest Irix implementation, but a mechanism for incrementing
>> the warning counter was never implemented, as documented in the
>> xfs_quota(8) man page. We do know from the historical archive that
>> it was never incremented at runtime during quota reservation
>> operations.
>>
>> With this commit, the warning counter quickly increments for every
>> allocation attempt after the user has crossed a quote soft
>> limit threshold, and this in turn transitions the user to hard
>> quota failures, rendering soft quota thresholds and timers useless.
>> This was reported as a regression by users.
>>
>> Because the intended behavior of this warning counter has never been
>> understood or documented, and the result of this change is a regression
>> in soft quota functionality, revert this commit to make soft quota
>> limits and timers operable again.
>>
>> Fixes: 4b8628d57b72 ("xfs: actually bump warning counts when we send warnings)
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>
> Assuming you're also going to send a patch to nuke xfs/144 is on its
> way...
Sure thing :)
