On Tue, Apr 26, 2022 at 04:25:54AM +0000, Catherine Hoang wrote:
> > On Apr 25, 2022, at 6:33 PM, Eric Sandeen <sandeen@xxxxxxxxxx> wrote:
> >
> > This reverts commit 4b8628d57b725b32616965e66975fcdebe008fe7.
> >
> > XFS quota has had the concept of a "quota warning limit" since
> > the earliest Irix implementation, but a mechanism for incrementing
> > the warning counter was never implemented, as documented in the
> > xfs_quota(8) man page. We do know from the historical archive that
> > it was never incremented at runtime during quota reservation
> > operations.
> >
> > With this commit, the warning counter quickly increments for every
> > allocation attempt after the user has crossed a quote soft
> > limit threshold, and this in turn transitions the user to hard
> > quota failures, rendering soft quota thresholds and timers useless.
> > This was reported as a regression by users.
> >
> > Because the intended behavior of this warning counter has never been
> > understood or documented, and the result of this change is a regression
> > in soft quota functionality, revert this commit to make soft quota
> > limits and timers operable again.
> >
> > Fixes: 4b8628d57b72 ("xfs: actually bump warning counts when we send warnings)
> > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
>
> This looks fine to me. I’m also happy to work on removing the rest of the
> quota warning infrastructure.
>
> Reviewed-by: Catherine Hoang <catherine.hoang@xxxxxxxxxx>
Thanks, Catherine!
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
