On Fri, Apr 15, 2022 at 04:42:33PM +0300, Amir Goldstein wrote: > > Hi Darrick, that's another story, you don't need to worry about that in this case :) > > I'd like to ack this patch, but hope to move it from generic/ to shared/ . Maybe > > Eryu can help to move it, or I can do that after I get the push permission. > > > > The reason why I intend moving it to shared is: > > Although we are trying to get rid of tests/shared/, but the tests/shared/ still help to > > remind us what cases are still not real generic cases. We'll try to help all shared > > cases to be generic. When the time is ready, I'd like to move this case to generic/ > > and change _supported_fs from "xfs btrfs ext4" to "generic". > > > > Sorry, but I have to object to this move. > I do not think that is what tests/shared should be used for. > > My preferences are: > 1. _suppoted_fs generic && _require_xfs_io_command "finsert" There is: "verb=finsert _require_xfs_io_command $verb" This patch has not only one case, different cases test different mode of fallocate, and I think Darrick has given them different _require_xfs_io_command. > 2. _suppoted_fs generic > 3. _supported_fs xfs btrfs ext4 (without moving to tests/shared) There's not any generic cases write like this, only shared cases like that. My personal opinion is *(2)* or make it shared if it insists "_supported_fs xfs btrfs ext4" (then will move it back to generic and "_suppoted_fs generic" when Darrick think it's time). Thanks, Zorro > > Thanks, > Amir. >
