On 11 Apr 2022 at 06:01, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> 5.18 w/ std=gnu11 compiled with gcc-5 wants flags stored in unsigned
> fields to be unsigned.
>
Looks good.
Reviewed-by: Chandan Babu R <chandan.babu@xxxxxxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
> fs/xfs/xfs_trans.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/xfs_trans.h b/fs/xfs/xfs_trans.h
> index de177842b951..569b68fc6912 100644
> --- a/fs/xfs/xfs_trans.h
> +++ b/fs/xfs/xfs_trans.h
> @@ -58,10 +58,10 @@ struct xfs_log_item {
> #define XFS_LI_DIRTY 3 /* log item dirty in transaction */
>
> #define XFS_LI_FLAGS \
> - { (1 << XFS_LI_IN_AIL), "IN_AIL" }, \
> - { (1 << XFS_LI_ABORTED), "ABORTED" }, \
> - { (1 << XFS_LI_FAILED), "FAILED" }, \
> - { (1 << XFS_LI_DIRTY), "DIRTY" }
> + { (1u << XFS_LI_IN_AIL), "IN_AIL" }, \
> + { (1u << XFS_LI_ABORTED), "ABORTED" }, \
> + { (1u << XFS_LI_FAILED), "FAILED" }, \
> + { (1u << XFS_LI_DIRTY), "DIRTY" }
>
> struct xfs_item_ops {
> unsigned flags;
--
chandan
