On 11 Apr 2022 at 18:23, Chandan Babu R wrote: > On 11 Apr 2022 at 06:01, Dave Chinner wrote: >> From: Dave Chinner <dchinner@xxxxxxxxxx> >> >> 5.18 w/ std=gnu11 compiled with gcc-5 wants flags stored in unsigned >> fields to be unsigned. >> > > The fourth argument of xfs_itruncate_extents_flags() and the return type of > xfs_bmapi_aflag() must be unsigned int. > > Also, the data type of bmapi_flags variable in xfs_iomap_write_direct() and > xfs_fs_map_blocks() should be unsigned int. Please ignore the above two statements. The corresponding code has values being assigned to a signed int variable rather than an unsigned int variable. > > The remaining changes look good to me. > > Reviewed-by: Chandan Babu R <chandan.babu@xxxxxxxxxx> > >> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> -- chandan
