On 11 Apr 2022 at 06:01, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
>
> 5.18 w/ std=gnu11 compiled with gcc-5 wants flags stored in unsigned
> fields to be unsigned.
>
> This touches xfs_fs.h so affects the user API, but the user API
> fields are also unsigned so the flags should really be unsigned,
> too.
>
Looks good to me.
Reviewed-by: Chandan Babu R <chandan.babu@xxxxxxxxxx>
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> ---
> fs/xfs/libxfs/xfs_fs.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_fs.h b/fs/xfs/libxfs/xfs_fs.h
> index 505533c43a92..52c9d8676fa3 100644
> --- a/fs/xfs/libxfs/xfs_fs.h
> +++ b/fs/xfs/libxfs/xfs_fs.h
> @@ -699,34 +699,34 @@ struct xfs_scrub_metadata {
> #define XFS_SCRUB_TYPE_NR 25
>
> /* i: Repair this metadata. */
> -#define XFS_SCRUB_IFLAG_REPAIR (1 << 0)
> +#define XFS_SCRUB_IFLAG_REPAIR (1u << 0)
>
> /* o: Metadata object needs repair. */
> -#define XFS_SCRUB_OFLAG_CORRUPT (1 << 1)
> +#define XFS_SCRUB_OFLAG_CORRUPT (1u << 1)
>
> /*
> * o: Metadata object could be optimized. It's not corrupt, but
> * we could improve on it somehow.
> */
> -#define XFS_SCRUB_OFLAG_PREEN (1 << 2)
> +#define XFS_SCRUB_OFLAG_PREEN (1u << 2)
>
> /* o: Cross-referencing failed. */
> -#define XFS_SCRUB_OFLAG_XFAIL (1 << 3)
> +#define XFS_SCRUB_OFLAG_XFAIL (1u << 3)
>
> /* o: Metadata object disagrees with cross-referenced metadata. */
> -#define XFS_SCRUB_OFLAG_XCORRUPT (1 << 4)
> +#define XFS_SCRUB_OFLAG_XCORRUPT (1u << 4)
>
> /* o: Scan was not complete. */
> -#define XFS_SCRUB_OFLAG_INCOMPLETE (1 << 5)
> +#define XFS_SCRUB_OFLAG_INCOMPLETE (1u << 5)
>
> /* o: Metadata object looked funny but isn't corrupt. */
> -#define XFS_SCRUB_OFLAG_WARNING (1 << 6)
> +#define XFS_SCRUB_OFLAG_WARNING (1u << 6)
>
> /*
> * o: IFLAG_REPAIR was set but metadata object did not need fixing or
> * optimization and has therefore not been altered.
> */
> -#define XFS_SCRUB_OFLAG_NO_REPAIR_NEEDED (1 << 7)
> +#define XFS_SCRUB_OFLAG_NO_REPAIR_NEEDED (1u << 7)
>
> #define XFS_SCRUB_FLAGS_IN (XFS_SCRUB_IFLAG_REPAIR)
> #define XFS_SCRUB_FLAGS_OUT (XFS_SCRUB_OFLAG_CORRUPT | \
--
chandan
