On Mon, Apr 04, 2022 at 06:31:03PM -0500, Eric Sandeen wrote: > For starters I know the lack of if / else if in the co is a little > ugly but smashing into 80cols was uglier... > > Here are the changes in log size for various filesystem geometries > (differing block sizes and filesystem sizes, with and without stripe > geometry to increase AG count). "--" means mkfs failed. > > Blocksize: 4096 > | orig | new > size | log striped | log striped > ------------------------------------------------------- > 128m | 5m m | 5m m > 256m | 5m 18m | 5m 18m > 511m | 5m 18m | 5m 18m > 512m | 5m 18m | 64m 18m > 513m | 5m 18m | 64m 64m > 1024m | 10m 18m | 64m 64m > 2047m | 10m 18m | 64m 64m > 2048m | 10m 18m | 64m 64m > 2049m | 10m 18m | 64m 64m > 4g | 10m 20m | 64m 64m > 8g | 10m 20m | 64m 64m > 15g | 10m 20m | 64m 64m > 16g | 10m 20m | 64m 64m > 17g | 10m 20m | 64m 64m > 32g | 16m 20m | 64m 64m > 64g | 32m 32m | 64m 64m > 256g | 128m 128m | 128m 128m > 512g | 256m 256m | 256m 256m > 1t | 512m 512m | 512m 512m > 2t | 1024m 1024m | 1024m 1024m > 4t | 2038m 2038m | 2038m 2038m > 8t | 2038m 2038m | 2038m 2038m > > Blocksize: 1024 > | orig | new > size | log striped | log striped > ------------------------------------------------------------------------------ > 128m | 3m 15m | 3m 15m > 256m | 3m 15m | 3m 15m > 511m | 3m 15m | 3m 15m > 512m | 3m 15m | 64m 15m > 513m | 3m 15m | 64m 64m > 1024m | 10m 15m | 64m 64m > 2047m | 10m 16m | 64m 64m > 2048m | 10m 16m | 64m 64m > 2049m | 10m 16m | 64m 64m > 4g | 10m 16m | 64m 64m > 8g | 10m 16m | 64m 64m > 15g | 10m 16m | 64m 64m > 16g | 10m 16m | 64m 64m > 17g | 10m 16m | 64m 64m > 32g | 16m 16m | 64m 64m > 64g | 32m 32m | 64m 64m > 256g | 128m 128m | 128m 128m > 512g | 256m 256m | 256m 256m > 1t | 512m 512m | 512m 512m > 2t | 1024m 1024m | 1024m 1024m > 4t | 1024m 1024m | 1024m 1024m > 8t | 1024m 1024m | 1024m 1024m > > Blocksize: 65536 > | orig | new > size | log striped | log striped > ------------------------------------------------------------------------------ > 128m | -- -- | -- -- > 256m | 32m -- | 32m -- > 511m | 32m 32m | 32m 32m > 512m | 32m 32m | 64m 32m > 513m | 32m 32m | 64m 63m > 1024m | 32m 32m | 64m 64m > 2047m | 56m 45m | 64m 64m > 2048m | 56m 45m | 64m 64m > 2049m | 56m 45m | 64m 64m > 4g | 56m 69m | 64m 69m > 8g | 56m 69m | 64m 69m > 15g | 56m 69m | 64m 69m > 16g | 56m 69m | 64m 69m > 17g | 56m 69m | 64m 69m > 32g | 56m 69m | 64m 69m > 64g | 56m 69m | 64m 69m > 256g | 128m 128m | 128m 128m > 512g | 256m 256m | 256m 256m > 1t | 512m 512m | 512m 512m > 2t | 1024m 1024m | 1024m 1024m > 4t | 2038m 2038m | 2038m 2038m > 8t | 2038m 2038m | 2038m 2038m Those new sizes look good to me. Acked-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx
