On Wed, Mar 30, 2022 at 06:38:05PM -0700, Jonathan Lassoff wrote: > Rather than have a constructor to define many nearly-identical > functions, use preprocessor macros to pass down a kernel logging level > to a common function. > > Signed-off-by: Jonathan Lassoff <jof@xxxxxxxxxx> > Reviewed-by: Chris Down <chris@xxxxxxxxxxxxxx> Looks good, minor nit below. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> > -#ifdef DEBUG > -define_xfs_printk_level(xfs_debug, KERN_DEBUG); > -#endif > +void > +xfs_printk_level( > + const char *kern_level, > + const struct xfs_mount *mp, > + const char *fmt, ...) Whitespace still not quite right. I'll clean that up myself up on merge, though. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
