> if (XFS_TEST_ERROR(error, log->l_mp, XFS_ERRTAG_IODONE_IOERR)) {
> xfs_alert(log->l_mp, "log I/O error %d", error);
> - xfs_force_shutdown(log->l_mp, SHUTDOWN_LOG_IO_ERROR);
> + xlog_force_shutdown(log, SHUTDOWN_LOG_IO_ERROR);
The SHUTDOWN_LOG_IO_ERROR as an API to xlog_force_shutdown looks
really weird now. It s only used to do the xfs_log_force at the
very beginning of the function. I'd suggest to drop the argument
and just do that manually in the two callers that do not have
SHUTDOWN_LOG_IO_ERROR set unconditionally. (This is a perfectly
fine follow on patch, though).
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@xxxxxx>
