On Sun, Mar 27, 2022 at 09:58:33AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Infinite loops in kernel code are scary. Calls to xfs_reserve_blocks > should be rare (people should just use the defaults!) so we really don't > need to try so hard. Simplify the logic here by removing the infinite > loop. > > Cc: Brian Foster <bfoster@xxxxxxxxxx> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> Looks good. Callers are already expected to handle failure because ENOSPC, so removing the loop and returning ENOSPC on failure is fine by me. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx