On 3/22/2022 1:44 AM, Christoph Hellwig wrote: > On Sat, Mar 19, 2022 at 12:28:30AM -0600, Jane Chu wrote: >> Mark poisoned page as not present, and to reverse the 'np' effect, >> restate the _PAGE_PRESENT bit. Please refer to discussions here for >> reason behind the decision. >> https://lore.kernel.org/all/CAPcyv4hrXPb1tASBZUg-GgdVs0OOFKXMXLiHmktg_kFi7YBMyQ@xxxxxxxxxxxxxx/ > > I think it would be good to summarize the conclusion here instead of > just linking to it. Sure, will do. > >> +static int _set_memory_present(unsigned long addr, int numpages) >> +{ >> + return change_page_attr_set(&addr, numpages, __pgprot(_PAGE_PRESENT), 0); >> +} > > What is the point of this trivial helper with a single caller? > Okay, will remove the helper. thanks! -jane
