Re: [PATCH 1/2] xfs: constify the name argument to various directory functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 10, 2022 at 01:53:48PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> Various directory functions do not modify their @name parameter,
> so mark it const to make that clear.  This will enable us to mark
> the global xfs_name_dotdot variable as const to prevent mischief.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  fs/xfs/libxfs/xfs_dir2.c      |   30 +++++++++++++++---------------
>  fs/xfs/libxfs/xfs_dir2.h      |    6 +++---
>  fs/xfs/libxfs/xfs_dir2_priv.h |    5 +++--
>  fs/xfs/xfs_inode.c            |    6 +++---
>  fs/xfs/xfs_inode.h            |    2 +-
>  fs/xfs/xfs_trace.h            |    4 ++--
>  6 files changed, 27 insertions(+), 26 deletions(-)

Looks good. And a couple less typedefs, too, as an added bonus :)

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux