On 16 Feb 2022 at 07:07, Allison Henderson wrote:
> Add an error tag on xfs_da3_split to test log attribute recovery
> and replay.
>
Looks good to me.
Reviewed-by: Chandan Babu R <chandan.babu@xxxxxxxxxx>
> Signed-off-by: Catherine Hoang <catherine.hoang@xxxxxxxxxx>
> Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
> Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> Signed-off-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
> ---
> fs/xfs/libxfs/xfs_da_btree.c | 4 ++++
> fs/xfs/libxfs/xfs_errortag.h | 4 +++-
> fs/xfs/xfs_error.c | 3 +++
> 3 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_da_btree.c b/fs/xfs/libxfs/xfs_da_btree.c
> index 9dc1ecb9713d..aa74f3fdb571 100644
> --- a/fs/xfs/libxfs/xfs_da_btree.c
> +++ b/fs/xfs/libxfs/xfs_da_btree.c
> @@ -22,6 +22,7 @@
> #include "xfs_trace.h"
> #include "xfs_buf_item.h"
> #include "xfs_log.h"
> +#include "xfs_errortag.h"
>
> /*
> * xfs_da_btree.c
> @@ -482,6 +483,9 @@ xfs_da3_split(
>
> trace_xfs_da_split(state->args);
>
> + if (XFS_TEST_ERROR(false, state->mp, XFS_ERRTAG_DA_LEAF_SPLIT))
> + return -EIO;
> +
> /*
> * Walk back up the tree splitting/inserting/adjusting as necessary.
> * If we need to insert and there isn't room, split the node, then
> diff --git a/fs/xfs/libxfs/xfs_errortag.h b/fs/xfs/libxfs/xfs_errortag.h
> index c15d2340220c..6d06a502bbdf 100644
> --- a/fs/xfs/libxfs/xfs_errortag.h
> +++ b/fs/xfs/libxfs/xfs_errortag.h
> @@ -60,7 +60,8 @@
> #define XFS_ERRTAG_BMAP_ALLOC_MINLEN_EXTENT 37
> #define XFS_ERRTAG_AG_RESV_FAIL 38
> #define XFS_ERRTAG_LARP 39
> -#define XFS_ERRTAG_MAX 40
> +#define XFS_ERRTAG_DA_LEAF_SPLIT 40
> +#define XFS_ERRTAG_MAX 41
>
> /*
> * Random factors for above tags, 1 means always, 2 means 1/2 time, etc.
> @@ -105,5 +106,6 @@
> #define XFS_RANDOM_BMAP_ALLOC_MINLEN_EXTENT 1
> #define XFS_RANDOM_AG_RESV_FAIL 1
> #define XFS_RANDOM_LARP 1
> +#define XFS_RANDOM_DA_LEAF_SPLIT 1
>
> #endif /* __XFS_ERRORTAG_H_ */
> diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c
> index 666f4837b1e1..2aa5d4d2b30a 100644
> --- a/fs/xfs/xfs_error.c
> +++ b/fs/xfs/xfs_error.c
> @@ -58,6 +58,7 @@ static unsigned int xfs_errortag_random_default[] = {
> XFS_RANDOM_BMAP_ALLOC_MINLEN_EXTENT,
> XFS_RANDOM_AG_RESV_FAIL,
> XFS_RANDOM_LARP,
> + XFS_RANDOM_DA_LEAF_SPLIT,
> };
>
> struct xfs_errortag_attr {
> @@ -172,6 +173,7 @@ XFS_ERRORTAG_ATTR_RW(reduce_max_iextents, XFS_ERRTAG_REDUCE_MAX_IEXTENTS);
> XFS_ERRORTAG_ATTR_RW(bmap_alloc_minlen_extent, XFS_ERRTAG_BMAP_ALLOC_MINLEN_EXTENT);
> XFS_ERRORTAG_ATTR_RW(ag_resv_fail, XFS_ERRTAG_AG_RESV_FAIL);
> XFS_ERRORTAG_ATTR_RW(larp, XFS_ERRTAG_LARP);
> +XFS_ERRORTAG_ATTR_RW(da_leaf_split, XFS_ERRTAG_DA_LEAF_SPLIT);
>
> static struct attribute *xfs_errortag_attrs[] = {
> XFS_ERRORTAG_ATTR_LIST(noerror),
> @@ -214,6 +216,7 @@ static struct attribute *xfs_errortag_attrs[] = {
> XFS_ERRORTAG_ATTR_LIST(bmap_alloc_minlen_extent),
> XFS_ERRORTAG_ATTR_LIST(ag_resv_fail),
> XFS_ERRORTAG_ATTR_LIST(larp),
> + XFS_ERRORTAG_ATTR_LIST(da_leaf_split),
> NULL,
> };
> ATTRIBUTE_GROUPS(xfs_errortag);
--
chandan
