Re: [PATCH v10 5/9] fsdax: Introduce dax_load_page()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v10 5/9] fsdax: Introduce dax_load_page()
From: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
Date: Wed, 16 Feb 2022 11:02:26 +0800
Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, linux-xfs <linux-xfs@xxxxxxxxxxxxxxx>, Linux NVDIMM <nvdimm@xxxxxxxxxxxxxxx>, Linux MM <linux-mm@xxxxxxxxx>, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, "Darrick J. Wong" <djwong@xxxxxxxxxx>, david <david@xxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Jane Chu <jane.chu@xxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
In-reply-to: <CAPcyv4jWuWWWBAEesMorK+LL6GVyqf-=VSChdw6P8txtckC=aw@mail.gmail.com>
Ironport-data: A9a23:VyhoJaxH54bFJIxjJOt6t+dIxyrEfRIJ4+MujC/XYbTApDhwhGNUyWAdWTrVPf+CYWugc9AkPd7lphwGusPUm9ZnHQtv/xmBbVoQ95OdWo7xwmQcns+qBpSaChohtq3yU/GYRCwPZiKa9kfF3oTJ9yEmj/nSHuOkUYYoBwgqLeNaYHZ44f5cs75h6mJYqYDR7zKl4bsekeWGULOW82Ic3lYv1k62gEgHUMIeF98vlgdWifhj5DcynpSOZX4VDfnZw3DQGuG4EgMmLtsvwo1V/kuBl/ssItij1LjmcEwWWaOUNg+L4pZUc/H6xEEc+WppieBmXBYfQR4/ZzGhhc14zs5c85K2UhsBMLDOmfgGTl9TFCQW0ahuoeWefCjl65PJp6HBWz62qxl0N2k6NJMZ9s55G2ZL8uYSKSxLZReG78q2y7KTS+9inM0vIcDneoQFtRlIwTjfS/RgXpHHR6TD4MRw3TEsi8QIFvHbD+IVayVoahvoYBBVPFoTTpUkk4+Agnj5bi0drVe9prQ+6GuVyxZ+uJDrLtbUf9miQcROgl3eomPA4nS/DhwEXPSfwjqt9mmwwOPC9Qv5UYQfUra469ZtmlSYwmFVAxoTPXO/oP+kmguwQN5SNUEQ0jQhoLJ090GxSNT5GRqirxasuh8aRsoVEOAg7gyJ4rTb7hzfBWUeSDNFLts8u6ceQT0sy0/Mj93yLSJgvafTSn+H8LqQ6zSoNkAowcUqDcMfZVJdpYC9/8do1VSSJuuP2ZWd1rXdcQwcCRjQxMTmu4gusA==
Ironport-hdrordr: A9a23:Tw3XBqNG1Rzw+sBcTv2jsMiBIKoaSvp037BL7TEUdfUxSKGlfq+V8sjzqiWftN98YhAdcLO7Scy9qBHnhP1ICOAqVN/MYOCMghrLEGgN1+vf6gylMyj/28oY7q14bpV5YeeaMXFKyer8/ym0euxN/OW6
References: <20220127124058.1172422-1-ruansy.fnst@fujitsu.com> <20220127124058.1172422-6-ruansy.fnst@fujitsu.com> <CAPcyv4jWuWWWBAEesMorK+LL6GVyqf-=VSChdw6P8txtckC=aw@mail.gmail.com>
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0



在 2022/2/16 9:34, Dan Williams 写道:

On Thu, Jan 27, 2022 at 4:41 AM Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx> wrote:


The current dax_lock_page() locks dax entry by obtaining mapping and
index in page.  To support 1-to-N RMAP in NVDIMM, we need a new function
to lock a specific dax entry


I do not see a call to dax_lock_entry() in this function, what keeps
this lookup valid after xas_unlock_irq()?

I am not sure if I understood your advice correctly: You saiddax_lock_entry() is not necessary in v9[1]. So, I deleted it.

[1]:https://lore.kernel.org/linux-xfs/CAPcyv4jVDfpHb1DCW+NLXH2YBgLghCVy8o6wrc02CXx4g-Bv7Q@xxxxxxxxxxxxxx/



--
Thanks,
Ruan.

Follow-Ups:
- Re: [PATCH v10 5/9] fsdax: Introduce dax_load_page()
  - From: Dan Williams

References:
- [PATCH v10 0/9] fsdax: introduce fs query to support reflink
  - From: Shiyang Ruan
- [PATCH v10 5/9] fsdax: Introduce dax_load_page()
  - From: Shiyang Ruan
- Re: [PATCH v10 5/9] fsdax: Introduce dax_load_page()
  - From: Dan Williams

Prev by Date: Re: [PATCH v10 9/9] fsdax: set a CoW flag when associate reflink mappings
Next by Date: Re: [PATCH v10 5/9] fsdax: Introduce dax_load_page()
Previous by thread: Re: [PATCH v10 5/9] fsdax: Introduce dax_load_page()
Next by thread: Re: [PATCH v10 5/9] fsdax: Introduce dax_load_page()
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]