On Thu, Jan 20, 2022 at 01:04:17AM -0800, Eric Biggers wrote: > I actually had changed this from v9 because fscrypt_dio_supported() seemed > backwards, given that its purpose is to check whether DIO is unsupported, not > whether it's supported per se (and the function's comment reflected this). What > ext4 and f2fs do is check a list of reasons why DIO would *not* be supported, > and if none apply, then it is supported. This is just one of those reasons. > > This is subjective though, so if people prefer the old way, I'll change it back. I find non-negated API much better and would also help with undinwinding the ext4/f2fs mess. But I'm not going to block the series on such a minor detail, of course.
