On 05 Jan 2022 at 05:20, Darrick J. Wong wrote:
> On Tue, Dec 14, 2021 at 02:15:08PM +0530, Chandan Babu R wrote:
>> A future commit will increase the width of xfs_extnum_t in order to facilitate
>> larger per-inode extent counters. Hence this patch now uses basic types to
>> define xfs_log_dinode->[di_nextents|dianextents].
>>
>> Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx>
>
> I wonder how this didn't trip the xfs_ondisk.h checks in the last
> revision of the patches, but ... who cares, let's see what I think of
> how /this/ version handles the field enlargements.
>
This change was part of "xfs: Rename inode's extent counter fields based on
their width" patch in v3 patchset. As Dave had correctly complained, this
change had to be done in a separate patch.
> Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> --D
>
>> ---
>> fs/xfs/libxfs/xfs_log_format.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h
>> index b322db523d65..fd66e70248f7 100644
>> --- a/fs/xfs/libxfs/xfs_log_format.h
>> +++ b/fs/xfs/libxfs/xfs_log_format.h
>> @@ -396,8 +396,8 @@ struct xfs_log_dinode {
>> xfs_fsize_t di_size; /* number of bytes in file */
>> xfs_rfsblock_t di_nblocks; /* # of direct & btree blocks used */
>> xfs_extlen_t di_extsize; /* basic/minimum extent size for file */
>> - xfs_extnum_t di_nextents; /* number of extents in data fork */
>> - xfs_aextnum_t di_anextents; /* number of extents in attribute fork*/
>> + uint32_t di_nextents; /* number of extents in data fork */
>> + uint16_t di_anextents; /* number of extents in attribute fork*/
>> uint8_t di_forkoff; /* attr fork offs, <<3 for 64b align */
>> int8_t di_aformat; /* format of attr fork's data */
>> uint32_t di_dmevmask; /* DMIG event mask */
>> --
>> 2.30.2
>>
--
chandan
