On Wed, Dec 15, 2021 at 05:09:32PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > When xfs_scrub encounters a directory with a leaf1 block, it tries to > validate that the leaf1 block's bestcount (aka the best free count of > each directory data block) is the correct size. Previously, this author > believed that comparing bestcount to the directory isize (since > directory data blocks are under isize, and leaf/bestfree blocks are > above it) was sufficient. > > Unfortunately during testing of online repair, it was discovered that it > is possible to create a directory with a hole between the last directory > block and isize. We have xfs_da3_swap_lastblock() that can leave an -empty- da block between the last referenced block and isize, but that's not a "hole" in the file. If you don't mean xfs_da3_swap_lastblock(), then can you clarify what you mean by a "hole" here and explain to me how the situation it occurs in comes about? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
