Re: [PATCH] Avoid format truncation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 14, 2021 at 11:14:58PM +0200, Boian Bonev wrote:
> io.c:644:17: note: ‘snprintf’ output between 4 and 14 bytes into a destination of size 8
> 
> Signed-off-by: Boian Bonev <bbonev@xxxxxxxxxx>

I really hope nobody ever gets to a cursor depth of 4 billion, but the
logic is correct, so...

Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>

--D

> ---
>  db/io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/db/io.c b/db/io.c
> index c79cf105..154c3bd9 100644
> --- a/db/io.c
> +++ b/db/io.c
> @@ -638,7 +638,7 @@ stack_f(
>  	char	**argv)
>  {
>  	int	i;
> -	char	tagbuf[8];
> +	char	tagbuf[14];
>  
>  	for (i = iocur_sp; i > 0; i--) {
>  		snprintf(tagbuf, sizeof(tagbuf), "%d: ", i);
> -- 
> 2.33.1
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux