On Tue, Oct 26, 2021 at 08:48:34AM -0700, Darrick J. Wong wrote: > On Tue, Oct 26, 2021 at 10:12:17PM +0800, JeffleXu wrote: > > Hi, > > > > Recently I'm working on supporting per-file DAX for virtiofs [1]. Vivek > > Goyal and I are interested [2] why the default behavior has changed > > since introduction of per-file DAX on ext4 and xfs [3][4]. > > > > That is, before the introduction of per-file DAX, when user doesn't > > specify '-o dax', DAX is disabled for all files. After supporting > > per-file DAX, when neither '-o dax' nor '-o dax=always|inode|never' is > > specified, it actually works in a '-o dax=inode' way if the underlying > > blkdev is DAX capable, i.e. depending on the persistent inode flag. That > > is, the default behavior has changed from user's perspective. > > > > We are not sure if this is intentional or not. Appreciate if anyone > > could offer some hint. > > Yes, that was an intentional change to all three filesystems to make the > steps we expose to sysadmins/users consistent and documented officially: > > https://lore.kernel.org/linux-fsdevel/20200429043328.411431-1-ira.weiny@xxxxxxxxx/ Ok, so basically new dax options semantics are different from old "-o dax". - dax=inode is default. This is change of behavior from old "-o dax" where default was *no dax* at all. - I tried xfs and mount does not fail even if user mounted with "-o dax=inode" and underlying block device does not support dax. That's little strange. Some users might expect a failure if certain mount option can't be enabled. So in general, what's the expected behavior with filesystem mount options. If user passes a mount option and it can't be enabled, should filesystem return error and force user to try again without the certain mount option or silently fallback to something else. I think in the past I have come across overlayfs users which demanded that mount fails if certain overlayfs option they have passed in can't be honored. They want to know about it so that they can either fix the configuration or change mount option. - With xfs, I mounted /dev/pmem0 with "-o dax=inode" and checked /proc/mounts and I don't see "dax=inode" there. Is that intentional? I am just trying to wrap my head around the new semantics as we are trying to implement those for virtiofs. So following is the side affects of behavior change. A. If somebody wrote scripts and scanned for mount flags to decide whehter dax is enabled or not, these will not work anymore. scripts will have to be changed to stat() every file in filesystem and look for STATX_ATTR_DAX flag to determine dax status. I would have thought to not make dax=inode default and let user opt-in for that using "dax=inode" mount option. But I guess people liked dax=inode default better. Anway, I guess if we want to keep the behavior of virtiofs in-line with ext4/xfs, we might have to make dax=inode default (atleast in client). Server default might be different because querying the state of FS_XFLAG_DAX is extra ioctl() call on each LOOKUP and GETATTR call and those who don't want to use DAX, might not want to pay this cost. Thanks Vivek > > (This was the first step; ext* were converted as separate series around > the same time.) > > --D > > > > > > > [1] https://lore.kernel.org/all/YW2Oj4FrIB8do3zX@xxxxxxxxxx/T/ > > [2] > > https://lore.kernel.org/all/YW2Oj4FrIB8do3zX@xxxxxxxxxx/T/#mf067498887ca2023c64c8b8f6aec879557eb28f8 > > [3] 9cb20f94afcd2964944f9468e38da736ee855b19 ("fs/ext4: Make DAX mount > > option a tri-state") > > [4] 02beb2686ff964884756c581d513e103542dcc6a ("fs/xfs: Make DAX mount > > option a tri-state") > > > > > > -- > > Thanks, > > Jeffle >
