Re: [PATCH 11/17] xfs: rename m_ag_maxlevels to m_allocbt_maxlevels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 15, 2021 at 09:52:10AM +1100, Dave Chinner wrote:
> On Thu, Oct 14, 2021 at 01:17:55PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> > 
> > Years ago when XFS was thought to be much more simple, we introduced
> > m_ag_maxlevels to specify the maximum btree height of per-AG btrees for
> > a given filesystem mount.  Then we observed that inode btrees don't
> > actually have the same height and split that off; and now we have rmap
> > and refcount btrees with much different geometries and separate
> > maxlevels variables.
> > 
> > The 'ag' part of the name doesn't make much sense anymore, so rename
> > this to m_allocbt_maxlevels to reinforce that this is the maximum height
>                  ^^
> You named it m_alloc_maxlevels....

Oops, fixed.

--D

> > of the *free space* btrees.  This sets us up for the next patch, which
> > will add a variable to track the maximum height of all AG btrees.
> > 
> > (Also take the opportunity to improve adjacent comments and fix minor
> > style problems.)
> > 
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > ---
> >  fs/xfs/libxfs/xfs_alloc.c       |   19 +++++++++++--------
> >  fs/xfs/libxfs/xfs_alloc.h       |    2 +-
> >  fs/xfs/libxfs/xfs_alloc_btree.c |    4 ++--
> >  fs/xfs/libxfs/xfs_trans_resv.c  |    2 +-
> >  fs/xfs/libxfs/xfs_trans_space.h |    2 +-
> >  fs/xfs/scrub/agheader.c         |    4 ++--
> >  fs/xfs/scrub/agheader_repair.c  |    4 ++--
> >  fs/xfs/xfs_mount.h              |    4 ++--
> >  8 files changed, 22 insertions(+), 19 deletions(-)
> 
> Other than that minor nit, the change looks good.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> -- 
> Dave Chinner
> david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux