Re: [PATCH 02/15] xfs: reduce the size of nr_ops for refcount btree cursors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 12, 2021 at 04:32:44PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> We're never going to run more than 4 billion btree operations on a
> refcount cursor, so shrink the field to an unsigned int to reduce the
> structure size.  Fix whitespace alignment too.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  fs/xfs/libxfs/xfs_btree.h |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> 
> diff --git a/fs/xfs/libxfs/xfs_btree.h b/fs/xfs/libxfs/xfs_btree.h
> index 49ecc496238f..1018bcc43d66 100644
> --- a/fs/xfs/libxfs/xfs_btree.h
> +++ b/fs/xfs/libxfs/xfs_btree.h
> @@ -181,18 +181,18 @@ union xfs_btree_irec {
>  
>  /* Per-AG btree information. */
>  struct xfs_btree_cur_ag {
> -	struct xfs_perag	*pag;
> +	struct xfs_perag		*pag;
>  	union {
>  		struct xfs_buf		*agbp;
>  		struct xbtree_afakeroot	*afake;	/* for staging cursor */
>  	};
>  	union {
>  		struct {
> -			unsigned long nr_ops;	/* # record updates */
> -			int	shape_changes;	/* # of extent splits */
> +			unsigned int	nr_ops;	/* # record updates */
> +			unsigned int	shape_changes;	/* # of extent splits */
>  		} refc;
>  		struct {
> -			bool	active;		/* allocation cursor state */
> +			bool		active;	/* allocation cursor state */
>  		} abt;
>  	};
>  };

Much nicer.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux