Re: [PATCH v2 4/4] common/log: Fix *_dump_log routines for ext4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Oct 8, 2021, at 10:49 AM, Allison Henderson <allison.henderson@xxxxxxxxxx> wrote:
> 
> 
> 
> On 10/6/21 5:26 PM, Catherine Hoang wrote:
>> dumpe2fs -h displays the superblock contents, not the journal contents.
>> Use the logdump utility to dump the contents of the journal.
>> Signed-off-by: Catherine Hoang <catherine.hoang@xxxxxxxxxx>
> Looks good to me.  Thanks for the fix
> Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
Thanks for the review!
Catherine
> 
>> ---
>>  common/log | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> diff --git a/common/log b/common/log
>> index 0a9aaa7f..154f3959 100644
>> --- a/common/log
>> +++ b/common/log
>> @@ -229,7 +229,7 @@ _scratch_dump_log()
>>  		$DUMP_F2FS_PROG $SCRATCH_DEV
>>  		;;
>>  	ext4)
>> -		$DUMPE2FS_PROG -h $SCRATCH_DEV
>> +		$DEBUGFS_PROG -R "logdump -a" $SCRATCH_DEV
>>  		;;
>>  	*)
>>  		;;
>> @@ -246,7 +246,7 @@ _test_dump_log()
>>  		$DUMP_F2FS_PROG $TEST_DEV
>>  		;;
>>  	ext4)
>> -		$DUMPE2FS_PROG -h $TEST_DEV
>> +		$DEBUGFS_PROG -R "logdump -a" $TEST_DEV
>>  		;;
>>  	*)
>>  		;;





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux