From: Dave Chinner <dchinner@xxxxxxxxxx>
These provide the kernel spinlock_t interface, but are *not*
spinlocks. Spinlocks cannot be used by general purpose userspace
processes due to the fact they cannot control task preemption and
scheduling reliability. Hence these are implemented as a
pthread_mutex_t, similar to the way the kernel RT build implements
spinlock_t as a kernel mutex.
Because the current libxfs spinlock "implementation" just makes
spinlocks go away, we have to also add initialisation to spinlocks
that libxfs uses that are missing from the userspace implementation.
Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
[chandan.babu@xxxxxxxxxx: Initialize inode log item spin lock]
Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx>
---
include/Makefile | 1 +
include/libxfs.h | 1 +
include/spinlock.h | 25 +++++++++++++++++++++++++
include/xfs_inode.h | 1 +
include/xfs_mount.h | 2 ++
include/xfs_trans.h | 1 +
libxfs/init.c | 4 +++-
libxfs/libxfs_priv.h | 4 +---
libxfs/logitem.c | 4 +++-
libxfs/rdwr.c | 2 ++
10 files changed, 40 insertions(+), 5 deletions(-)
create mode 100644 include/spinlock.h
diff --git a/include/Makefile b/include/Makefile
index 632b819f..f7c40a5c 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -16,6 +16,7 @@ LIBHFILES = libxfs.h \
kmem.h \
list.h \
parent.h \
+ spinlock.h \
xfs_inode.h \
xfs_log_recover.h \
xfs_metadump.h \
diff --git a/include/libxfs.h b/include/libxfs.h
index bc07655e..a494a1d4 100644
--- a/include/libxfs.h
+++ b/include/libxfs.h
@@ -18,6 +18,7 @@
#include "kmem.h"
#include "libfrog/radix-tree.h"
#include "atomic.h"
+#include "spinlock.h"
#include "xfs_types.h"
#include "xfs_fs.h"
diff --git a/include/spinlock.h b/include/spinlock.h
new file mode 100644
index 00000000..8da2325c
--- /dev/null
+++ b/include/spinlock.h
@@ -0,0 +1,25 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2019-20 RedHat, Inc.
+ * All Rights Reserved.
+ */
+#ifndef __LIBXFS_SPINLOCK_H__
+#define __LIBXFS_SPINLOCK_H__
+
+/*
+ * This implements kernel compatible spinlock exclusion semantics. These,
+ * however, are not spinlocks, as spinlocks cannot be reliably implemented in
+ * userspace without using realtime scheduling task contexts. Hence this
+ * interface is implemented with pthread mutexes and so can block, but this is
+ * no different to the kernel RT build which replaces spinlocks with mutexes.
+ * Hence we know it works.
+ */
+
+typedef pthread_mutex_t spinlock_t;
+
+#define spin_lock_init(l) pthread_mutex_init(l, NULL)
+#define spin_lock(l) pthread_mutex_lock(l)
+#define spin_trylock(l) (pthread_mutex_trylock(l) != EBUSY)
+#define spin_unlock(l) pthread_mutex_unlock(l)
+
+#endif /* __LIBXFS_SPINLOCK_H__ */
diff --git a/include/xfs_inode.h b/include/xfs_inode.h
index 0551fe45..08a62d83 100644
--- a/include/xfs_inode.h
+++ b/include/xfs_inode.h
@@ -43,6 +43,7 @@ struct inode {
struct timespec64 i_atime;
struct timespec64 i_mtime;
struct timespec64 i_ctime;
+ spinlock_t i_lock;
};
static inline uint32_t i_uid_read(struct inode *inode)
diff --git a/include/xfs_mount.h b/include/xfs_mount.h
index 12019c4b..2f320880 100644
--- a/include/xfs_mount.h
+++ b/include/xfs_mount.h
@@ -22,6 +22,7 @@ typedef struct xfs_mount {
#define m_icount m_sb.sb_icount
#define m_ifree m_sb.sb_ifree
#define m_fdblocks m_sb.sb_fdblocks
+ spinlock_t m_sb_lock;
/*
* Bitsets of per-fs metadata that have been checked and/or are sick.
@@ -32,6 +33,7 @@ typedef struct xfs_mount {
char *m_fsname; /* filesystem name */
int m_bsize; /* fs logical block size */
+ spinlock_t m_agirotor_lock;
xfs_agnumber_t m_agfrotor; /* last ag where space found */
xfs_agnumber_t m_agirotor; /* last ag dir inode alloced */
xfs_agnumber_t m_maxagi; /* highest inode alloc group */
diff --git a/include/xfs_trans.h b/include/xfs_trans.h
index ad76ecfd..2c55bb85 100644
--- a/include/xfs_trans.h
+++ b/include/xfs_trans.h
@@ -35,6 +35,7 @@ struct xfs_inode_log_item {
unsigned int ili_last_fields; /* fields when flushed*/
unsigned int ili_fields; /* fields to be logged */
unsigned int ili_fsync_fields; /* ignored by userspace */
+ spinlock_t ili_lock;
};
typedef struct xfs_buf_log_item {
diff --git a/libxfs/init.c b/libxfs/init.c
index b06faf8a..2c54546b 100644
--- a/libxfs/init.c
+++ b/libxfs/init.c
@@ -743,7 +743,9 @@ libxfs_mount(
mp->m_flags = (LIBXFS_MOUNT_32BITINODES|LIBXFS_MOUNT_32BITINOOPT);
mp->m_sb = *sb;
INIT_RADIX_TREE(&mp->m_perag_tree, GFP_KERNEL);
- sbp = &(mp->m_sb);
+ sbp = &mp->m_sb;
+ spin_lock_init(&mp->m_sb_lock);
+ spin_lock_init(&mp->m_agirotor_lock);
xfs_sb_mount_common(mp, sb);
diff --git a/libxfs/libxfs_priv.h b/libxfs/libxfs_priv.h
index db90e173..e1e90268 100644
--- a/libxfs/libxfs_priv.h
+++ b/libxfs/libxfs_priv.h
@@ -48,6 +48,7 @@
#include "kmem.h"
#include "libfrog/radix-tree.h"
#include "atomic.h"
+#include "spinlock.h"
#include "xfs_types.h"
#include "xfs_arch.h"
@@ -205,9 +206,6 @@ enum ce { CE_DEBUG, CE_CONT, CE_NOTE, CE_WARN, CE_ALERT, CE_PANIC };
#endif
/* miscellaneous kernel routines not in user space */
-#define spin_lock_init(a) ((void) 0)
-#define spin_lock(a) ((void) 0)
-#define spin_unlock(a) ((void) 0)
#define likely(x) (x)
#define unlikely(x) (x)
diff --git a/libxfs/logitem.c b/libxfs/logitem.c
index 4d4e8080..b073cdb4 100644
--- a/libxfs/logitem.c
+++ b/libxfs/logitem.c
@@ -144,6 +144,8 @@ xfs_inode_item_init(
ip->i_ino, iip);
#endif
- xfs_log_item_init(mp, &iip->ili_item, XFS_LI_INODE);
+ spin_lock_init(&iip->ili_lock);
+
+ xfs_log_item_init(mp, &iip->ili_item, XFS_LI_INODE);
iip->ili_inode = ip;
}
diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 713ef9af..a5fd0596 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -1070,6 +1070,8 @@ libxfs_iget(
VFS_I(ip)->i_count = 1;
ip->i_ino = ino;
ip->i_mount = mp;
+ spin_lock_init(&VFS_I(ip)->i_lock);
+
error = xfs_imap(mp, tp, ip->i_ino, &ip->i_imap, 0);
if (error)
goto out_destroy;
--
2.30.2
