On Tue, Sep 21, 2021 at 09:56:02AM +0100, Christoph Hellwig wrote: > On Fri, Sep 17, 2021 at 06:29:59PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > The btree geometry computation function has an off-by-one error in that > > it does not allow maximally tall btrees (nlevels == XFS_BTREE_MAXLEVELS). > > This can result in repairs failing unnecessarily on very fragmented > > filesystems. Subsequent patches to remove MAXLEVELS usage in favor of > > the per-btree type computations will make this a much more likely > > occurrence. > > Shouldn't this go in first as a fix? It probably should, though I haven't seen any bug reports about this fault. I'll move it to the front of the patchset. --D > Looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
