Re: [PATCH 01/61] mkfs: move mkfs/proto.c declarations to mkfs/proto.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +extern char *setup_proto (char *fname);
> +extern void parse_proto (xfs_mount_t *mp, struct fsxattr *fsx, char **pp);
> +extern void res_failed (int err);

It might be worth to drop the externs, the spaces before the opening
braces and the xfs_mount_t typedef usage while you're at it.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux