On Thu, Aug 26, 2021 at 11:09:47AM -0700, Darrick J. Wong wrote:
> On Thu, Aug 26, 2021 at 12:30:12PM -0500, Bill O'Donnell wrote:
> > When dax-mode was tri-stated by adding dax=inode case, the EXPERIMENTAL
> > warning on mount was missed for the case. Add logic to handle the
> > warning similar to that of the 'dax=always' case.
> >
> > Signed-off-by: Bill O'Donnell <bodonnel@xxxxxxxxxx>
> > ---
> > fs/xfs/xfs_mount.h | 2 ++
> > fs/xfs/xfs_super.c | 8 +++++---
> > 2 files changed, 7 insertions(+), 3 deletions(-)
...
> > - if (xfs_has_dax_always(mp)) {
> > + if (xfs_has_dax_always(mp) || xfs_has_dax_inode(mp)) {
>
> Er... can't this be done without burning another feature bit by:
>
> if (xfs_has_dax_always(mp) || (!xfs_has_dax_always(mp) &&
> !xfs_has_dax_never(mp))) {
> ...
> xfs_warn(mp, "DAX IS EXPERIMENTAL");
> }
Not quite. This will be true at initialization.
-Bill
