Re: [PATCH v2 16/15] xfs: start documenting common units and tags used in tracepoints

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 19, 2021 at 03:27:17PM +0200, Carlos Maiolino wrote:
> On Wed, Aug 18, 2021 at 08:46:47PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> > 
> > Because there are a lot of tracepoints that express numeric data with
> > an associated unit and tag, document what they are to help everyone else
> > keep these thigns straight.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > ---
> > v2: update unit names, say that we want hex, and put related tag names together
> > ---
> ...
> > + * daddr: physical block number in 512b blocks
> > + * daddrcount: number of blocks in a physical extent, in 512b blocks
> 
> Shouldn't this be bbcount?

Yep, and the 'blockcount' above should be 'fsbcount' too.

Thanks for the reviews, everyone!

--D

> 
> Other than that, it looks good:
> 
> Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
> 
> -- 
> Carlos
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux