On Tue, Aug 17, 2021 at 04:42:50PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Some of our tracepoints describe fields as "blkno", "block", or "bno". > That name doesn't describe any units, which makes the fields not very > useful. Rename the fields to capture units and ensure the format is > hexadecimal. > > "startblock" is the startblock field from the bmap structure, which is a > segmented fsblock on the data device, or an rfsblock on the realtime > device. > "fileoff" is a file offset, in units of filesystem blocks > "daddr" is a raw device offset, in 512b blocks > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > fs/xfs/xfs_trace.h | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) Some nice cleanups in that lot :) Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx