On Thu, Aug 12, 2021 at 09:10:56AM +0100, Christoph Hellwig wrote: > On Tue, Aug 10, 2021 at 03:28:49PM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > Introduce a helper function xfs_buf_daddr() to extract the disk > > address of the buffer from the struct xfs_buf. This will replace > > direct accesses to bp->b_bn and bp->b_maps[0].bm_bn, as well as > > the XFS_BUF_ADDR() macro. > > > > This patch introduces the helper function and replaces all uses of > > XFS_BUF_ADDR() as this is just a simple sed replacement. > > The end result looks sane, but I would have preferred to do one patch > that just does the script rename of XFS_BUF_ADDR, and one ore more to > clean up the rest. Which is exactly what this patch does - I should have looked at it more carefully and not just the applied series. So maybe tweak the above commit message bit, otherwise: Reviewed-by: Christoph Hellwig <hch@xxxxxx>