Re: [PATCH 10/14] xfs: flush inode inactivation work when compiling usage statistics

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 04, 2021 at 07:07:17PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> Users have come to expect that the space accounting information in
> statfs and getquota reports are fairly accurate.  Now that we inactivate
> inodes from a background queue, these numbers can be thrown off by
> whatever resources are singly-owned by the inodes in the queue.  Flush
> the pending inactivations when userspace asks for a space usage report.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_qm_syscalls.c |    8 ++++++++
>  fs/xfs/xfs_super.c       |    3 +++
>  2 files changed, 11 insertions(+)

Makes sense. These aren't perf/latency sensitive operations, so
waiting on completion of a flush shouldn't be a big deal.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux