On 26 Jul 2021 at 23:30, Darrick J. Wong wrote:
> On Mon, Jul 26, 2021 at 05:15:30PM +0530, Chandan Babu R wrote:
>> Maximum values associated with extent counters i.e. Maximum extent length,
>> Maximum data extents and Maximum xattr extents are dictated by the on-disk
>> format. Hence move these definitions over to xfs_format.h.
>>
>> Signed-off-by: Chandan Babu R <chandanrlinux@xxxxxxxxx>
>> ---
>> fs/xfs/libxfs/xfs_format.h | 7 +++++++
>> fs/xfs/libxfs/xfs_types.h | 7 -------
>> 2 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
>> index 8cd48a651b96..37cca918d2ba 100644
>> --- a/fs/xfs/libxfs/xfs_format.h
>> +++ b/fs/xfs/libxfs/xfs_format.h
>> @@ -1109,6 +1109,13 @@ enum xfs_dinode_fmt {
>> { XFS_DINODE_FMT_BTREE, "btree" }, \
>> { XFS_DINODE_FMT_UUID, "uuid" }
>>
>> +/*
>> + * Max values for extlen, extnum, aextnum.
>> + */
>> +#define MAXEXTLEN ((uint32_t)0x001fffff) /* 21 bits */
>> +#define MAXEXTNUM ((int32_t)0x7fffffff) /* signed int */
>> +#define MAXAEXTNUM ((int16_t)0x7fff) /* signed short */
>
> Why do the cast types change here? This is a simple hoist, right?
Sorry, I will restore the casts to how it was earlier. I don't remember the
exact reason for changing them. I thought I had seen some compilation
issues. But after restoring them, I see that the code compiles fine.
--
chandan
