On Thu, Jul 22, 2021 at 09:26:08AM +0200, Christoph Hellwig wrote: > Disabling quota accounting is hairy, racy code with all kinds of pitfalls. > And it has a very strange mind set, as quota accounting (unlike > enforcement) really is a propery of the on-disk format. There is no good s/propery/property/ > use case for supporting this. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_trans_resv.c | 30 ---- > fs/xfs/libxfs/xfs_trans_resv.h | 2 - > fs/xfs/xfs_dquot_item.c | 134 ------------------ > fs/xfs/xfs_dquot_item.h | 17 --- > fs/xfs/xfs_qm.c | 2 +- > fs/xfs/xfs_qm.h | 3 - > fs/xfs/xfs_qm_syscalls.c | 241 ++------------------------------- > fs/xfs/xfs_trans_dquot.c | 38 ------ > 8 files changed, 13 insertions(+), 454 deletions(-) > <snip> I think you could delete more... > - /* > - * Give back all the dquot reference(s) held by inodes. > - * Here we go thru every single incore inode in this file system, and > - * do a dqrele on the i_udquot/i_gdquot that it may have. > - * Essentially, as long as somebody has an inode locked, this guarantees > - * that quotas will not be turned off. This is handy because in a > - * transaction once we lock the inode(s) and check for quotaon, we can > - * depend on the quota inodes (and other things) being valid as long as > - * we keep the lock(s). > - */ > - error = xfs_dqrele_all_inodes(mp, flags); > - ASSERT(!error); ...because I think xfs_dqrele_all_inodes has lost all of its callers. Can you please remove it and XFS_ICWALK_DQRELE from xfs_icache.[ch]? --D
