Re: [PATCH 1/3] xfs: remove support for disabling quota accounting on a mounted file system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 14, 2021 at 01:10:49PM +0200, Carlos Maiolino wrote:
> > -	mutex_unlock(&q->qi_quotaofflock);
> > -	return error;
> > +	/* XXX what to do if error ? Revert back to old vals incore ? */
>
> May be too strict, but I wonder if we shouldn't shut the FS down in case we fail
> here?

This is just the existing code being unindented by one level.  The
usual transaction commit failure cases will cause a shutdown anyway.



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux