On Sun, Jul 18, 2021 at 09:57:14PM +0800, Eryu Guan wrote:
> On Tue, Jul 06, 2021 at 05:21:04PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> >
> > Alter the ./new script so that one can set the test id explicitly.
> >
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> Looks good to me. Mind updating the usage info as well?
Will do and resubmit. Thanks for reviewing the rest of the patches. :)
--D
>
> Thanks,
> Eryu
>
> > ---
> > new | 14 ++++++++++++--
> > 1 file changed, 12 insertions(+), 2 deletions(-)
> >
> >
> > diff --git a/new b/new
> > index 07144399..51111f08 100755
> > --- a/new
> > +++ b/new
> > @@ -26,7 +26,18 @@ usage()
> > }
> >
> > [ $# -eq 0 ] && usage
> > -tdir=tests/$1
> > +
> > +if echo "$1" | grep -q '/'; then
> > + if [ -e "tests/$1" ]; then
> > + echo "$1: test already exists."
> > + exit 1
> > + fi
> > + tdir="tests/$(echo "$1" | cut -d '/' -f 1)"
> > + id="$(echo "$1" | cut -d '/' -f 2)"
> > +else
> > + tdir=tests/$1
> > + id="$(basename "$(./tools/nextid "$1")")"
> > +fi
> >
> > i=0
> > line=0
> > @@ -36,7 +47,6 @@ eof=1
> > export AWK_PROG="$(type -P awk)"
> > [ "$AWK_PROG" = "" ] && { echo "awk not found"; exit; }
> >
> > -id="$(basename "$(./tools/nextid "$1")")"
> > echo "Next test id is $id"
> > shift
> >
