On Wed, Jul 14, 2021 at 07:45:33PM +1000, Dave Chinner wrote: > That's what happens later in the patchset. The XFS_FEAT_ATTR2 is > set when either the mount option or the on-disk sb flag is set, and > it is overridden after log recovery (which can set the SB flag) if > the XFS_FEAT_NOATTR2 feature has been specified. I see where this is going. I still think keeping the logic changes together and killing XFS_MOUNT_ATTR2 here would be preferably, especially with all the documentation you have for the attr2 situation in the commit log here.
