Re: [PATCH 2/3] xfs: remove the flags argument to xfs_qm_dquot_walk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 12, 2021 at 01:14:25PM +0200, Christoph Hellwig wrote:
> We always purge all dquots now, so drop the argument.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Pretty straightforward, so
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>

--D

> ---
>  fs/xfs/xfs_qm.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> index 580b9dba21122b..2b34273d0405e7 100644
> --- a/fs/xfs/xfs_qm.c
> +++ b/fs/xfs/xfs_qm.c
> @@ -187,15 +187,11 @@ xfs_qm_dqpurge(
>   */
>  static void
>  xfs_qm_dqpurge_all(
> -	struct xfs_mount	*mp,
> -	uint			flags)
> +	struct xfs_mount	*mp)
>  {
> -	if (flags & XFS_QMOPT_UQUOTA)
> -		xfs_qm_dquot_walk(mp, XFS_DQTYPE_USER, xfs_qm_dqpurge, NULL);
> -	if (flags & XFS_QMOPT_GQUOTA)
> -		xfs_qm_dquot_walk(mp, XFS_DQTYPE_GROUP, xfs_qm_dqpurge, NULL);
> -	if (flags & XFS_QMOPT_PQUOTA)
> -		xfs_qm_dquot_walk(mp, XFS_DQTYPE_PROJ, xfs_qm_dqpurge, NULL);
> +	xfs_qm_dquot_walk(mp, XFS_DQTYPE_USER, xfs_qm_dqpurge, NULL);
> +	xfs_qm_dquot_walk(mp, XFS_DQTYPE_GROUP, xfs_qm_dqpurge, NULL);
> +	xfs_qm_dquot_walk(mp, XFS_DQTYPE_PROJ, xfs_qm_dqpurge, NULL);
>  }
>  
>  /*
> @@ -206,7 +202,7 @@ xfs_qm_unmount(
>  	struct xfs_mount	*mp)
>  {
>  	if (mp->m_quotainfo) {
> -		xfs_qm_dqpurge_all(mp, XFS_QMOPT_QUOTALL);
> +		xfs_qm_dqpurge_all(mp);
>  		xfs_qm_destroy_quotainfo(mp);
>  	}
>  }
> @@ -1359,7 +1355,7 @@ xfs_qm_quotacheck(
>  	 * at this point (because we intentionally didn't in dqget_noattach).
>  	 */
>  	if (error) {
> -		xfs_qm_dqpurge_all(mp, XFS_QMOPT_QUOTALL);
> +		xfs_qm_dqpurge_all(mp);
>  		goto error_return;
>  	}
>  
> -- 
> 2.30.2
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux