On Fri, Jul 02, 2021 at 09:15:35AM +0100, Christoph Hellwig wrote:
> > @@ -552,6 +552,7 @@ xfs_log_mount(
> > xfs_daddr_t blk_offset,
>
> > {
> > + struct xlog *log;
> > bool fatal = xfs_sb_version_hascrc(&mp->m_sb);
> > int error = 0;
> > int min_logfsbs;
> > @@ -566,11 +567,12 @@ xfs_log_mount(
> > ASSERT(mp->m_flags & XFS_MOUNT_RDONLY);
> > }
> >
> > - mp->m_log = xlog_alloc_log(mp, log_target, blk_offset, num_bblks);
> > - if (IS_ERR(mp->m_log)) {
> > - error = PTR_ERR(mp->m_log);
> > + log = xlog_alloc_log(mp, log_target, blk_offset, num_bblks);
> > + if (IS_ERR(log)) {
> > + error = PTR_ERR(log);
> > goto out;
> > }
> > + mp->m_log = log;
>
> Additition of the local variable here looks rather unrelated, given
> that the log is only touched twice in relation to the flags.
Same comment as Christoph -- if you wanted to split the variable cutout
into a separate patch, that's fine. Don't really care that much though.
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
--D
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
