On Fri, Jun 18, 2021 at 02:58:46PM +0100, Christoph Hellwig wrote: > On Thu, Jun 17, 2021 at 09:10:41AM -0700, Darrick J. Wong wrote: > > Um, we /do/ log the error already; a full shutdown report looks like: > > > > XFS (sda): xfs_do_force_shutdown(0x2) called from line 2440 of file > > fs/xfs/xfs_log.c. Return address = xfs_trans_mod_sb+0x25 > > XFS (sda): Corruption of in-memory data detected. Shutting down > > filesystem > > Yeah, it's pretty verbose. > > > Or are you saying that we should combine them into a single message? > > > > XFS (sda): Corruption of in-memory data detected at xlog_write+0x10 > > (fs/xfs/xfs_log.c:2440). Shutting down filesystem. > > > > XFS (sda): Log I/O error detected at xlog_write+0x10 > > (fs/xfs/xfs_log.c:2440). Shutting down filesystem. > > > > XFS (sda): I/O error detected at xlog_write+0x10 > > (fs/xfs/xfs_log.c:2440). Shutting down filesystem. > > > > etc? > > I think that reads much nicer. So if we cause some churn in this area > we might as well go with that. Ok, I'll prepare a new patch to consolidate all that. --D
