On Thu, Jun 17, 2021 at 12:23:12PM -0400, Brian Foster wrote: > On Wed, Jun 16, 2021 at 06:32:07PM +0200, Christoph Hellwig wrote: > > Add a new helper to copy the log iovec into the in-core log buffer, > > and open code the handling continuation opheader as a special case. > > > > What do you mean by "open code the handling continuation opheader?" This is left from my commit message when this and the next patch were still one and relates to the then removed xlog_write_adv_cnt helper. In the current form it makes no sense, so I'll reword the commit message.