On 16 Jun 2021 at 22:02, Christoph Hellwig wrote:
> Turn ic_datap from a char into a void pointer given that it points
> to arbitrary data.
>
xlog_alloc_log() has the following statement,
iclog->ic_datap = (char *)iclog->ic_data + log->l_iclog_hsize;
Maybe the "char *" typecast can be converted to "void *" as part of this
patch.
The remaining changes look good to me.
Reviewed-by: Chandan Babu R <chandanrlinux@xxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> fs/xfs/xfs_log.c | 2 +-
> fs/xfs/xfs_log_priv.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
> index e921b554b68367..8999c78f3ac6d9 100644
> --- a/fs/xfs/xfs_log.c
> +++ b/fs/xfs/xfs_log.c
> @@ -3613,7 +3613,7 @@ xlog_verify_iclog(
> if (field_offset & 0x1ff) {
> clientid = ophead->oh_clientid;
> } else {
> - idx = BTOBBT((char *)&ophead->oh_clientid - iclog->ic_datap);
> + idx = BTOBBT((void *)&ophead->oh_clientid - iclog->ic_datap);
> if (idx >= (XLOG_HEADER_CYCLE_SIZE / BBSIZE)) {
> j = idx / (XLOG_HEADER_CYCLE_SIZE / BBSIZE);
> k = idx % (XLOG_HEADER_CYCLE_SIZE / BBSIZE);
> diff --git a/fs/xfs/xfs_log_priv.h b/fs/xfs/xfs_log_priv.h
> index e4e421a7033558..96dbe713954f7e 100644
> --- a/fs/xfs/xfs_log_priv.h
> +++ b/fs/xfs/xfs_log_priv.h
> @@ -185,7 +185,7 @@ typedef struct xlog_in_core {
> u32 ic_offset;
> enum xlog_iclog_state ic_state;
> unsigned int ic_flags;
> - char *ic_datap; /* pointer to iclog data */
> + void *ic_datap; /* pointer to iclog data */
>
> /* Callback structures need their own cacheline */
> spinlock_t ic_callback_lock ____cacheline_aligned_in_smp;
--
chandan
