On Thu, Jun 17, 2021 at 01:28:24PM -0700, Darrick J. Wong wrote: > On Thu, Jun 17, 2021 at 06:26:15PM +1000, Dave Chinner wrote: > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > > > In preparation for moving more CIL context specific functionality > > into these operations. > > > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > > Looks fine as a hoist, though I wonder why you didn't do this in patch > 4? Because I wanted to keep the xlog_write() api change separate to relocating the lsn code out of xlog_write(). There are enough review comments of "don't move and modify in the one patch" that I won't even bother trying to do even simple "move and modify" operations in a single patch anymore. I can combine them if you want, but then someone is bound to pop up in another review cycle and say "please separate....". :/ -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
