On Thu, Jun 17, 2021 at 10:50:39AM -0700, Darrick J. Wong wrote: > On Thu, Jun 17, 2021 at 06:26:12PM +1000, Dave Chinner wrote: > > diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c > > index 2fb0ab02dda3..2c8b25888c53 100644 > > --- a/fs/xfs/xfs_log_cil.c > > +++ b/fs/xfs/xfs_log_cil.c > > @@ -783,6 +783,48 @@ xlog_cil_build_trans_hdr( > > tic->t_curr_res -= lvhdr->lv_bytes; > > } > > > > +/* > > + * Write out the commit record of a checkpoint transaction associated with the > > + * given ticket to close off a running log write. Return the lsn of the commit > > + * record. > > + */ > > +int > > static int, like the robot suggests? Huh. How did that get dropped? I definitely made this static in the original patch.... > With that fixed, > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> Ta. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
