Re: [PATCH 03/16] xfs: detach dquots from inode if we don't need to inactivate it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 13, 2021 at 10:20:13AM -0700, Darrick J. Wong wrote:
> -	xfs_inactive(ip);
> +	if (!need_inactive) {
> +		/* Going straight to reclaim, so drop the dquots. */
> +		xfs_qm_dqdetach(ip);
> +	} else {
> +		xfs_inactive(ip);
> +	}

It seems like most of the checks contained in xfs_inode_needs_inactive
could be dropped from xfs_inactive now.

But given that I feel the heat already I'm not going to suggest that
now and just going to look into cleaning that up after the series
goes in..

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux